Add an all job for the test matrix #11880
Conversation
| all: | ||
| uses: ./.github/workflows/all.yml | ||
| if: always() | ||
| needs: | ||
| - macos | ||
| - ubuntu | ||
| - windows | ||
| with: | ||
| needs: ${{ toJSON(needs) }} |
There was a problem hiding this comment.
Hey, I noticed you're reinventing the wheel here :)
I've got this https://github.com/re-actors/alls-green implemented a while back. Inspired by PyCA and some other research.
| all: | |
| uses: ./.github/workflows/all.yml | |
| if: always() | |
| needs: | |
| - macos | |
| - ubuntu | |
| - windows | |
| with: | |
| needs: ${{ toJSON(needs) }} | |
| all: # This job does nothing and is only used for the branch protection | |
| if: always() | |
| needs: | |
| - macos | |
| - ubuntu | |
| - windows | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Decide whether the needed jobs succeeded or failed | |
| uses: re-actors/alls-green@release/v1 | |
| with: | |
| jobs: ${{ toJSON(needs) }} |
There was a problem hiding this comment.
I don't know about reinventing... pytest-dev/pytest-twisted@4c75379 :] but yes, thanks for the heads up on your action. I noticed it over in the towncrier comments as well. I'm glad to see this practice has some traction.
There was a problem hiding this comment.
Yeah, we've faced this problem in aiohttp where automerge would merge broken PRs and I've accidentally seen the solution in PyCA/cryptography, then gone ahead and generalized it a bit :)
There was a problem hiding this comment.
As for "one check for branch protection" idea, it's ancient. Coming from CIs like Zuul and Bors.
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
closing in favor of #20026 for logistical reasons. thanks 🇺🇦 |
No description provided.